Open
Conversation
…ntext Closes apache#322. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused Python Config / Rust PyConfig wrapper that could not be wired into SessionContext, simplifying the configuration surface area in line with #322.
Changes:
- Removed the
ConfigPython API export and the underlying RustPyConfigimplementation. - Updated concurrency tests to stop exercising the removed
Configclass and deleted now-obsolete config tests. - Added an upgrade guide entry documenting migration to
SessionConfig.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| python/tests/test_config.py | Removes tests that only validated the deleted Config API. |
| python/tests/test_concurrency.py | Drops Config usage/tests and updates the concurrent-access test description accordingly. |
| python/datafusion/init.py | Removes Config from public imports and __all__. |
| docs/source/user-guide/upgrade-guides.rst | Documents Config removal and shows SessionConfig replacement usage. |
| docs/source/contributor-guide/ffi.rst | Removes PyConfig example from PyO3 mutability guidelines section. |
| crates/core/src/lib.rs | Stops compiling/registering the config module and PyConfig class with the _internal module. |
| crates/core/src/config.rs | Deletes the unused PyConfig implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #322.
Rationale for this change
PyConfig is never actually used in our SessionContext or anywhere else. This PR just removes it.
What changes are included in this PR?
Removal of unused code.
Add a note in the migration guide.
Are there any user-facing changes?
Yes, but it's just removal of code that did not impact the running of
datafusion-python.